retour sur v5rc9

<?php  
/*
 * Project name: Flatboard 5
 * Project URL: https://flatboard.org
 * Author: Frédéric Kaplon and contributors
 * All Flatboard code is released under the GPL3 license.
 *
 * Flatboard 5 - Contrôleur Register
 */

namespace App\Controllers\Auth;

use App\Core\Controller;  
use App\Core\Session;  
use App\Core\Validator;  
use App\Core\RateLimiter;  
use App\Core\Config;  
use App\Models\User;  
use App\Services\EmailService;

class RegisterController extends Controller  
{  
    public function show()  
    {  
        if (Session::get('user_id')) {  
            $this->redirect(\App\Helpers\UrlHelper::to('/'));  
            return;  
        }

        $config = Config::getInstance();  
        if (!$config->get('registration_enabled', true)) {  
            Session::flash('error', \App\Helpers\Translator::trans('auth.registrationDisabled', [], 'errors'));  
            $this->redirect(\App\Helpers\UrlHelper::to('/'));  
            return;  
        }

        $config = Config::getInstance();  
        $forumTitle = $config->get('forum.title');  
        $forumDescription = $config->get('forum.description');  
        // Normaliser les chaînes vides en null  
        if ($forumTitle === '') {  
            $forumTitle = null;  
        }  
        if ($forumDescription === '') {  
            $forumDescription = null;  
        }  
        $siteDescription = $config->get('site_description', $forumDescription);  
        $pageTitle = \App\Helpers\Translator::trans('register.title', [], 'auth') ?: 'Register';

        $this->view('auth/register', [  
            'bannerType' => 'index',  
            'forumTitle' => $forumTitle,  
            'forumDescription' => $forumDescription,  
            'pageTitle' => $pageTitle,  
            'pageIcon' => 'fas fa-user-plus',  
            // SEO  
            'title' => $pageTitle,  
            'description' => $siteDescription,  
            'canonical' => '/register',  
        ], 'frontend');  
    }

    public function register()  
    {  
        $limiter = new RateLimiter();  
        $ip = $this->request->getIp();

        // Vérifier si l'IP est bannie  
        if (\App\Models\Ban::isIpBanned($ip)) {  
            $ban = \App\Models\Ban::getActiveByIp($ip);  
            \App\Core\Logger::security('Registration attempt from banned IP', [  
                'ip' => $ip,  
                'email' => $this->request->get('email'),  
                'ban_id' => $ban['id'] ?? null  
            ]);  
            Session::flash('error', \App\Helpers\Translator::trans('auth.account.banned', [], 'errors') ?: 'Votre adresse IP a été bannie.');  
            $this->redirect(\App\Helpers\UrlHelper::to('/register'));  
            return;  
        }

        if (!$limiter->check('register', $ip)) {  
            \App\Core\Logger::security('Rate limit exceeded for registration attempt', [  
                'ip' => $ip,  
                'email' => $this->request->get('email')  
            ]);  
            Session::flash('error', \App\Helpers\Translator::trans('auth.tooManyRegisterAttempts', [], 'errors'));  
            $this->redirect(\App\Helpers\UrlHelper::to('/register'));  
            return;  
        }

        $config = Config::getInstance();  
        if (!$config->get('registration_enabled', true)) {  
            Session::flash('error', \App\Helpers\Translator::trans('auth.registrationDisabled', [], 'errors'));  
            $this->redirect(\App\Helpers\UrlHelper::to('/'));  
            return;  
        }

        $validator = new Validator($this->request->all());  
        $validator->required('username')
            ->min('username', 3)
            ->max('username', 30)
            ->regex('username', '/^[a-zA-Z0-9_-]+$/', \App\Helpers\Translator::trans('validation.username.invalidFormat', [], 'errors') ?: 'Le nom d\'utilisateur ne peut contenir que des lettres, chiffres, tirets et underscores');  
        $validator->required('email')->email('email');  
        $validator->required('password')->min('password', 8)->confirmed('password');

        if (!$validator->isValid()) {  
            Session::flash('errors', $validator->getErrors());  
            $this->redirect(\App\Helpers\UrlHelper::to('/register'));  
            return;  
        }

        $username = $this->request->get('username');  
        $email = $this->request->get('email');  
        $password = $this->request->get('password');

        // Vérifier si l'utilisateur existe déjà  
        if (User::findByEmail($email)) {  
            \App\Core\Logger::warning('Registration attempt with existing email', [  
                'ip' => $ip,  
                'email' => $email,  
                'username' => $username  
            ]);  
            Session::flash('error', \App\Helpers\Translator::trans('validation.email.alreadyUsed', [], 'errors'));  
            $this->redirect(\App\Helpers\UrlHelper::to('/register'));  
            return;  
        }

        if (User::findByUsername($username)) {  
            \App\Core\Logger::warning('Registration attempt with existing username', [  
                'ip' => $ip,  
                'email' => $email,  
                'username' => $username  
            ]);  
            Session::flash('error', \App\Helpers\Translator::trans('validation.username.alreadyUsed', [], 'errors'));  
            $this->redirect(\App\Helpers\UrlHelper::to('/register'));  
            return;  
        }

        $emailVerificationEnabled = $config->get('email_verification', false);

        // Initialiser les groupes et permissions par défaut si nécessaire  
        \App\Models\Group::initDefaults();  
        \App\Helpers\PermissionHelper::initDefaults();

        // Récupérer le groupe membre via GroupHelper (utilise le champ 'type', pas le nom)  
        // Permet le renommage libre du groupe sans casser la fonctionnalité  
        $memberGroupId = \App\Helpers\GroupHelper::getMemberGroupId();

        if (!$memberGroupId) {  
            // Si aucun groupe membre n'existe après l'initialisation, c'est une erreur critique  
            \App\Core\Logger::error('Member group not found after initialization', [  
                'ip' => $ip  
            ]);  
            Session::flash('error', \App\Helpers\Translator::trans('auth.system.error', [], 'errors') ?: 'Erreur système : groupe membre introuvable');  
            $this->redirect(\App\Helpers\UrlHelper::to('/register'));  
            return;  
        }

        // Créer l'utilisateur avec le groupe membre par défaut  
        try {  
            $userId = User::create([  
                'username' => $username,  
                'email' => $email,  
                'password' => $password,  
                'email_verified' => !$emailVerificationEnabled,  
                'group_id' => $memberGroupId  
            ]);  
        } catch (\Exception $e) {  
            // Gérer les violations de contrainte UNIQUE (race condition)  
            if ($e->getCode() == 409 || strpos($e->getMessage(), 'already exists') !== false) {  
                if (strpos($e->getMessage(), 'Email') !== false) {  
                    \App\Core\Logger::warning('Registration failed: Email already exists (race condition)', [  
                        'ip' => $ip,  
                        'email' => $email,  
                        'username' => $username  
                    ]);  
                    Session::flash('error', \App\Helpers\Translator::trans('validation.email.alreadyUsed', [], 'errors'));  
                } elseif (strpos($e->getMessage(), 'Username') !== false) {  
                    \App\Core\Logger::warning('Registration failed: Username already exists (race condition)', [  
                        'ip' => $ip,  
                        'email' => $email,  
                        'username' => $username  
                    ]);  
                    Session::flash('error', \App\Helpers\Translator::trans('validation.username.alreadyUsed', [], 'errors'));  
                } else {  
                    Session::flash('error', \App\Helpers\Translator::trans('general.errorOccurred', [], 'errors') ?: 'Erreur lors de l\'inscription');  
                }  
                $this->redirect(\App\Helpers\UrlHelper::to('/register'));  
                return;  
            }  
            // Relancer l'exception si ce n'est pas une contrainte UNIQUE  
            throw $e;  
        }

        \App\Core\Logger::info('New user registered', [  
            'user_id' => $userId,  
            'username' => $username,  
            'email' => $email,  
            'ip' => $ip,  
            'email_verified' => !$emailVerificationEnabled,  
            'group_id' => $memberGroupId  
        ]);

        // Déclencher l'événement user.registered via les plugins  
        if (class_exists('\App\Core\Plugin')) {  
            $createdUser = User::find($userId);  
            if ($createdUser) {  
                \App\Core\Plugin::trigger('user.registered', $createdUser);  
            }  
        }

        // Envoyer l'email de vérification si nécessaire  
        if ($emailVerificationEnabled) {  
            $token = bin2hex(random_bytes(32));  
            $expiresAt = time() + (3600 * 24 * 7); // 7 jours

            // Stocker le token  
            $storage = \App\Storage\StorageFactory::create();  
            $storage->createEmailVerificationToken($userId, $token, $expiresAt);

            // Envoyer l'email  
            $emailService = new EmailService();  
            $siteUrl = rtrim($config->get('site_url', ''), '/');  
            $verificationUrl = $siteUrl . '/verify-email?token=' . $token;  
            $emailService->sendVerification($email, $token, $verificationUrl);

            Session::flash('success', \App\Helpers\Translator::trans('register.successVerifyEmail', [], 'auth'));  
            $this->redirect(\App\Helpers\UrlHelper::to('/login'));  
        } else {  
            // Connecter automatiquement si la vérification email n'est pas activée  
            Session::set('user_id', $userId);  
            Session::set('username', $username);  
            // Déterminer is_admin depuis le groupe  
            $isAdmin = \App\Helpers\GroupHelper::isAdmin($userId);  
            Session::set('is_admin', $isAdmin);  
            Session::flash('success', \App\Helpers\Translator::trans('register.success', [], 'auth'));  
            $this->redirect(\App\Helpers\UrlHelper::to('/'));  
        }  
    }  
}